fix(local_names): add missing ARIA attributes #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of implementing
ARIAMixin
(servo/servo#32079), it seems that, as a first step,html5ever
would need to update its list of ARIA attributes inlocal_names.txt
to correspond to those defined inARIAMixin
.(If
html5ever
does not have these attributes defined inlocal_names.txt
, then changes toelement.rs
such as this fail to compile.)This PR adds the missing ARIA attributes:
However, I did not remove the currently-defined ARIA attributes which are not available in
ARIAMixin
:I assume these are deprecated/nonstandard, but I don't see a strong reason to remove them since I'm not sure if any downstream code is relying on them. (Update: it turns out the WPT tests still reference
aria-relevant
.)BTW I did not find any tests for the existing
aria-*
attributes, but I'd be happy to add them as necessary.